Skip to content

[fix] components: serial_v2: preserve RT_DEVICE_FLAG_STREAM when reop…#11348

Open
RCSN wants to merge 1 commit intoRT-Thread:masterfrom
RCSN:bugfix/serial_preserve_stream_flag
Open

[fix] components: serial_v2: preserve RT_DEVICE_FLAG_STREAM when reop…#11348
RCSN wants to merge 1 commit intoRT-Thread:masterfrom
RCSN:bugfix/serial_preserve_stream_flag

Conversation

@RCSN
Copy link
Copy Markdown
Contributor

@RCSN RCSN commented Apr 28, 2026

并确认并列出已经在什么情况或板卡上进行了测试。
And confirm in which case or board has been tested. -->
HPM6750EVK2

为什么提交这份PR (why to submit this PR)

当使能posix io device时候

image image

msh回车不会移回行首，而是以梯形变化显示，缺少了\r字符

你的解决方案是什么 (what is your solution)

posix使用serail open时候调用serial_fops_open，会先close再open，会导致把flag的RT_DEVICE_FLAG_STREAM覆盖掉，需要先保存flag再close

请提供验证的bsp和config (provide the config and bsp)

  • BSP: HPM6750EVK2 bsp 1.11.0，可在rtthread stduio下载，其他平台应该也有类似问题

@RCSN
[fix] components: serial_v2: preserve RT_DEVICE_FLAG_STREAM when reop…
86eea67 
…ening serial device

- The serial_fops_open function closes and reopens the serial device,but the RT_DEVICE_FLAG_STREAM flag was not preserved across the close/open cycle. This change saves the STREAM flag before close and restores it during reopen to ensure consistent behavior.

Signed-off-by: Runcheng Lu <[email protected]>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：bugfix/serial_preserve_stream_flag
  • 设置PR number为 \ Set the PR number to：11348
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 bugfix/serial_preserve_stream_flag 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the bugfix/serial_preserve_stream_flag branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/serial/dev_serial_v2.c

🏷️ Tag: components_driver_serial_v2

Reviewers: @Ryan-CW-Code

Changed Files (Click to expand)
  • components/drivers/serial/dev_serial_v2.c

📊 Current Review Status (Last Updated: 2026-04-28 15:41 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Ryan-CW-Code
Copy link
Copy Markdown
Contributor

Ryan-CW-Code commented Apr 29, 2026

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

component: drivers/serial component: drivers Component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RCSN @Ryan-CW-Code